vet

commit fe6e575b3352b2d33082b5bd3b0a94ac74394b18
parent f074273939ce18cf8935b040d093e9d15a91855a
Author: andrewlaack-collab <andrew.laack@imbue.com>
Date:   Tue, 10 Feb 2026 09:53:40 +0000

Andrew/better code reviews (#47)

* Update issues found to use github review format instead of pr comments.

* Update wording

* Better wording again

* Added tests for github formatting

* Added comment, updated wording to be more consistent

* whitespace

* Don't redirect errors, useful for debugging.

* Refactoring to make exit status codes more sensible (realized 1 was default error for python failures so shouldn't be using that for issues found).

* Fix comment fallback behavior

* Updated exit status code descriptors

* Less noisy
Diffstat:
M
.github/workflows/vet.yml
 | 
2
+-
M
README.md
 | 
2
+-

2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/vet.yml b/.github/workflows/vet.yml
@@ -44,7 +44,7 @@ jobs:
             '. + {commit_id: $sha}' "$RUNNER_TEMP/review.json" > "$RUNNER_TEMP/review-final.json"
 
           gh api "repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews" \
-            --method POST --input "$RUNNER_TEMP/review-final.json" || \
+            --method POST --input "$RUNNER_TEMP/review-final.json" > /dev/null || \
             gh pr comment "${{ github.event.pull_request.number }}" \
               --body "$(jq -r '[.body] + [.comments[] | "**\(.path):\(.line)**\n\n\(.body)"] | join("\n\n---\n\n")' "$RUNNER_TEMP/review-final.json")"
           exit 0
diff --git a/README.md b/README.md
@@ -75,7 +75,7 @@ jobs:
             '. + {commit_id: $sha}' "$RUNNER_TEMP/review.json" > "$RUNNER_TEMP/review-final.json"
 
           gh api "repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews" \
-            --method POST --input "$RUNNER_TEMP/review-final.json" || \
+            --method POST --input "$RUNNER_TEMP/review-final.json" > /dev/null || \
             gh pr comment "${{ github.event.pull_request.number }}" \
               --body "$(jq -r '[.body] + [.comments[] | "**\(.path):\(.line)**\n\n\(.body)"] | join("\n\n---\n\n")' "$RUNNER_TEMP/review-final.json")"
           exit 0